feat(upgrade): add v1.3.0 upgrade handler (release/1.3.x)#247
Merged
Conversation
phenix3443
approved these changes
Jun 3, 2026
Registers a no-op v1.3.0 upgrade handler that runs module migrations, slotted between the v1.2.0 handler and the testnet-only handlers in app/app.go. No module consensus versions or store keys change in v1.3.x (the SDK gas-meter changes from moca-cosmos-sdk#125 only affect runtime gas semantics; the dropped proto fields are not persisted), so the handler is a pure RunMigrations noop. Mirrors #246 (the main-branch counterpart).
puneet2019
force-pushed
the
feat/upgrade-handler-v1.3.0-1.3.x
branch
from
7918288 to
a32c277
Compare
Contributor
Author
|
Resolved the merge conflict (DIRTY status): rebased onto current Remaining red CI checks are all release/1.3.x baseline failures, not introduced by this PR — verified against #244 which has the identical 4 failures on the same base:
The change itself: |
This was referenced Jun 3, 2026
puneet2019
added a commit
that referenced
this pull request
Jun 4, 2026
The governance + comprehensive upgrade tests default to UPGRADE_NAME=v2.0.0 in the scripts, which works on main (#221 registered the v2.0.0 handler for the x/erc20 store delete) but NOT on release/1.3.x. release/1.3.x only has v1.1.0 / v1.2.0 / v1.3.0 (#247) handlers, so the proposal panics with: UPGRADE "v2.0.0" NEEDED at height: 49 panic: runtime error: invalid memory address or nil pointer dereference github.com/evmos/evmos/v12/app.(*Evmos).FinalizeBlock.func1() app/app.go:1160 +0x1d (Hardfork mode passed because it doesn't go through the upgrade module's handler lookup.) Mirroring the existing OLD_VERSION pattern: - Add an `upgrade_name` workflow_dispatch input. - Default to v1.3.0 — the natural upgrade target on this branch. - Plumb to UPGRADE_NAME env so the test scripts' \${UPGRADE_NAME:-v2.0.0} fallback is overridden uniformly across all matrix jobs.
puneet2019
added a commit
that referenced
this pull request
Jun 4, 2026
* feat(e2e): backport e2e/kind framework to release/1.3.x Backports the Kind-based E2E framework (originally added on main via #105 and follow-ups) onto release/1.3.x so the same upgrade-flow and smoke tests run on this branch's PRs. Should have been part of #247 (the v1.3.0 upgrade handler). This PR is the follow-up that wires the test harness. Includes: - e2e/kind/ (framework, scripts, manifests, contracts, tests incl. test_upgrade_hardfork.sh / test_upgrade_governance.sh) - .github/workflows/e2e-kind.yml (per-PR + workflow_dispatch) - .github/workflows/notify-e2e.yml (moca-e2e hub cross-repo trigger) - Makefile e2e-fw / e2e-kind-* targets Snapshot taken from main HEAD at backport time. No app/SDK code touched. * chore(e2e): adapt e2e-kind.yml for release/1.3.x context - PR trigger: branches main -> release/1.3.x (so this workflow runs on PRs against release/1.3.x). - Default old_version: v1.1.2 -> v1.2.1 (matches the natural upgrade source for release/1.3.x; main targets a different floor). Leaves notify-e2e.yml's `branches: [main]` filter unchanged — the moca-e2e hub tracks main only, so this workflow stays a safe no-op on release/1.3.x by design. * fix(e2e): set UPGRADE_NAME=v1.3.0 default for release/1.3.x The governance + comprehensive upgrade tests default to UPGRADE_NAME=v2.0.0 in the scripts, which works on main (#221 registered the v2.0.0 handler for the x/erc20 store delete) but NOT on release/1.3.x. release/1.3.x only has v1.1.0 / v1.2.0 / v1.3.0 (#247) handlers, so the proposal panics with: UPGRADE "v2.0.0" NEEDED at height: 49 panic: runtime error: invalid memory address or nil pointer dereference github.com/evmos/evmos/v12/app.(*Evmos).FinalizeBlock.func1() app/app.go:1160 +0x1d (Hardfork mode passed because it doesn't go through the upgrade module's handler lookup.) Mirroring the existing OLD_VERSION pattern: - Add an `upgrade_name` workflow_dispatch input. - Default to v1.3.0 — the natural upgrade target on this branch. - Plumb to UPGRADE_NAME env so the test scripts' \${UPGRADE_NAME:-v2.0.0} fallback is overridden uniformly across all matrix jobs. * fix(e2e): align upgrade test script defaults with release/1.3.x The three upgrade test scripts defaulted to OLD_VERSION=v1.2.0 and UPGRADE_NAME=v2.0.0 (correct for main, where #221 registered the v2.0.0 handler). On release/1.3.x there is no v2.0.0 handler, so running e.g. `make e2e-fw-test TEST=upgrade_governance` locally without overrides hit: UPGRADE "v2.0.0" NEEDED at height: 49 panic: runtime error: invalid memory address or nil pointer dereference Aligns the local script defaults with the CI workflow defaults set in a5634ae / 18c3477: e2e/kind/tests/test_upgrade_hardfork.sh e2e/kind/tests/test_upgrade_governance.sh e2e/kind/tests/test_upgrade_comprehensive.sh OLD_VERSION v1.2.0 -> v1.2.1 UPGRADE_NAME v2.0.0 -> v1.3.0 (also the example commands in the usage headers) So `make e2e-fw-test TEST=upgrade_governance` on release/1.3.x now exercises the same v1.2.1 -> v1.3.0 path as the CI workflow's default dispatch. Resolves phenix3443's review point 2 on #255. * docs(e2e): sync README with release/1.3.x defaults - OLD_VERSION examples: v12.0.1 (stale evmos-era tag, never valid on any moca release) -> v1.2.1, matching the script + workflow defaults on this branch (aef131b / a5634ae). Three occurrences in e2e/kind/README.md. - CI section: workflow runs automatically on PRs to `main` -> PRs to `release/1.3.x`, matching the workflow's pull_request trigger filter (a5634ae). Resolves phenix3443's follow-up review point 2 on #255.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Registers a no-op
v1.3.0upgrade handler inapp/app.go, slotted between the existingv1.2.0handler and the testnet-only handlers:Why a noop is correct for v1.3.x
The state-machine-affecting work targeted at v1.3.x does not require module migrations or store changes:
moca-cosmos-sdk#125(merged) — removes greenfield RW gas metering; runtime gas semantics only. Removed proto fields (GasInfo.rw_used,TxMsgData.extra_data) are not persisted by the app.moca-cosmos-sdk#126(open) — drops Nagqu free-reads gas config; runtime only.mocad snapshotscommand tree #243 on main / feat(cli): addmocad snapshotscommand tree (cherry-pick from #243) #244 on this branch) — operator tooling, no state-machine effect.So
RunMigrations(fromVM)alone covers v1.3.0 from any prior version.Companion PR
v1.2.0andv2.0.0).Test plan
go build ./app/...